Revert "ci: Only run functional tests on windows in master" #29059
Conversation
This reverts commit aba4a58.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
| if: github.event_name != 'pull_request' | ||
| run: py -3 test\functional\test_runner.py --jobs $env:NUMBER_OF_PROCESSORS --ci --quiet --tmpdirprefix=$env:RUNNER_TEMP --combinedlogslen=99999999 --timeout-factor=$env:TEST_RUNNER_TIMEOUT_FACTOR --extended | ||
| env: | ||
| TEST_RUNNER_EXTRA: ${{ github.event_name != 'pull_request' && '--extended' || '' }} |
There was a problem hiding this comment.
How much longer would it take to also run --extended?
There was a problem hiding this comment.
How much longer would it take to also run
--extended?
Appr. extra 10 minutes.
The feature_dbcrash.py test takes the longest time.
|
lgtm ACK 7b22cd8 |
|
Looks like these are still just randomly failing: #29090 ? |
Perhaps, it depends on the image version? That one was |
|
I don't think so. The last run on master passed with that image version: https://github.com/bitcoin/bitcoin/actions/runs/7214949583/job/19658167262. |
This PR reverts commit aba4a58 from #28567.
The Windows-specific code received quality and performance improvements recently. So there are no reasons to skip functional tests in PRs anymore.
In my own repo, I've run the GHA Windows job more than 100 times with no failure.