doc/reduce-traffic: update/clarify max outbound connection count #29052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
brunoerg
reviewed
Dec 11, 2023
MarnixCroes
force-pushed
the
doc-reduce-traffic
branch
from
aa4907a to
d58f89d
Compare
brunoerg
approved these changes
Dec 12, 2023
jonatack
reviewed
Jan 5, 2024
There was a problem hiding this comment.
Post-merge review ACK with logging sanity check
2024-01-05T21:54:39.437118Z [Init] m_max_automatic_connections: 125
2024-01-05T21:54:39.437125Z [Init] m_max_outbound_full_relay: 8
2024-01-05T21:54:39.437133Z [Init] m_max_outbound_block_relay: 2
2024-01-05T21:54:39.437139Z [Init] m_max_automatic_outbound: 11
2024-01-05T21:54:39.437145Z [Init] m_max_inbound: 114
| Of the 10 outbound peers, there can be 8 full-relay connections and 2 | ||
| block-relay-only ones. | ||
| By default, Bitcoin Core allows up to 125 connections to different peers, 11 of | ||
| which are outbound. You can therefore, have at most 114 inbound connections. |
There was a problem hiding this comment.
Perhaps just my read on this, but the following may have been clearer with respect to the inbound number also being the default setting only, and not an absolute limit.
Suggested change
| which are outbound. You can therefore, have at most 114 inbound connections. | |
| which are outbound and 114 are inbound. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #29046