Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix addnode functional test failure on OpenBSD #29035

Merged
merged 1 commit into from
Dec 11, 2023
Merged

test: fix addnode functional test failure on OpenBSD #29035

merged 1 commit into from
Dec 11, 2023

Conversation

theStack
Copy link
Contributor

@theStack theStack commented Dec 8, 2023

This is the functional test counterpart of PR #28891 / commit 007d6f0 (unfortunately, I missed it back then and only ran the unit tests -- sorry for the noise).

master branch on OpenBSD 7.4:

$ ./test/functional/rpc_net.py 
2023-12-08T17:29:05.057000Z TestFramework (INFO): PRNG seed is: 6024296850131317403
2023-12-08T17:29:05.058000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test_au3zchif
2023-12-08T17:29:05.618000Z TestFramework (INFO): Test getconnectioncount
2023-12-08T17:29:05.618000Z TestFramework (INFO): Test getpeerinfo
2023-12-08T17:29:06.643000Z TestFramework (INFO): Check getpeerinfo output before a version message was sent
2023-12-08T17:29:06.709000Z TestFramework (INFO): Test getnettotals
2023-12-08T17:29:06.773000Z TestFramework (INFO): Test getnetworkinfo
2023-12-08T17:29:06.978000Z TestFramework (INFO): Test addnode and getaddednodeinfo
2023-12-08T17:29:06.980000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/home/thestack/bitcoin/test/functional/test_framework/test_framework.py", line 131, in main
    self.run_test()
  File "/home/thestack/bitcoin/./test/functional/rpc_net.py", line 65, in run_test
    self.test_addnode_getaddednodeinfo()
  File "/home/thestack/bitcoin/./test/functional/rpc_net.py", line 224, in test_addnode_getaddednodeinfo
    assert_raises_rpc_error(-23, "Node already added", self.nodes[0].addnode, node=ip_port2, command='add')
  File "/home/thestack/bitcoin/test/functional/test_framework/util.py", line 131, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
AssertionError: No exception raised

On the PR branch, the same call succeeds.

@theStack
test: fix addnode functional test failure on OpenBSD
fd0bde2 
This is the functional test counterpart of PR bitcoin#28891 /
commit 007d6f0.
@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 8, 2023 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK kevkevinpal

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Tests label Dec 8, 2023
@kevkevinpal
Copy link
Contributor

ACK fd0bde2

@maflcko maflcko modified the milestone: 26.1 Dec 9, 2023
@maflcko
Copy link
Member

maflcko commented Dec 9, 2023

lgtm. Is the code in 26.x and does it need backport?

@theStack
Copy link
Contributor Author

theStack commented Dec 9, 2023

lgtm. Is the code in 26.x and does it need backport?

No backport needed, the PR containing the code (#28155, commit 94e8882) was merged to master after 26.x branched off.

@maflcko maflcko added this to the 27.0 milestone Dec 9, 2023
@fanquake fanquake merged commit 09ab9d4 into bitcoin:master Dec 11, 2023
16 checks passed
@theStack theStack deleted the 202312-test-fix_rpc_net_on_openbsd branch December 11, 2023 10:55
@bitcoin bitcoin locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
27.0
Development

Successfully merging this pull request may close these issues.
5 participants
@theStack @DrahtBot @kevkevinpal @maflcko @fanquake