pass exec_properties to underlying android_local_test macro #810
Conversation
Augustyniak
requested review from
cgruber,
timpeut and
restingbull
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| @@ -119,4 +120,5 @@ def kt_android_local_test( | |||
| manifest_values = manifest_values, | |||
| tags = kwargs.get("tags", default = None), | |||
| testonly = testonly, | |||
| exec_properties = exec_properties, | |||
There was a problem hiding this comment.
Wouldn't we want to also pass this to the rest of the targets that are created here so that the exec_properties are consistent for all targets?
There was a problem hiding this comment.
Makes sense 👍 I think that your comment should be addressed in 9c922b5
There was a problem hiding this comment.
https://github.com/bazelbuild/rules_kotlin/pull/810/files#diff-686482fb7b1546f7ba4e615a0e5f45354cf1f74934c3a31165571540ff96796dR68 the kt_android_library macro could use this property as well so that the two macros provide consistent attributes.
There was a problem hiding this comment.
OK, this time it should really be addressed in 9601771
Augustyniak
force-pushed
the
pass-exec-properties
branch
from
2441fb7 to
38258d2
Compare
Signed-off-by: Rafal Augustyniak <[email protected]>
Description: Add support for Kotlin robolectric tests by making `envoy_mobile_android_test` macro use `kt_android_local_test` maco as opposed to `android_local_test` macro as the former supports both Java and Kotlin files while the latter supports Java files only. The change should be additive when it comes to functionality. Bump `rules_kotlin` version to v1.7.0-RC-3 to pick up changes from bazelbuild/rules_kotlin#810. Risk Level: None Testing: Existing tests using envoy_mobile_android_test macro. Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak <[email protected]>
Description: Add support for Kotlin robolectric tests by making `envoy_mobile_android_test` macro use `kt_android_local_test` maco as opposed to `android_local_test` macro as the former supports both Java and Kotlin files while the latter supports Java files only. The change should be additive when it comes to functionality. Bump `rules_kotlin` version to v1.7.0-RC-3 to pick up changes from bazelbuild/rules_kotlin#810. Risk Level: None Testing: Existing tests using envoy_mobile_android_test macro. Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak <[email protected]> Signed-off-by: JP Simard <[email protected]>
exec_propertiesis supported byandroid_local_test, it should be supported bykt_android_local_testtoo.