Update Riak rpm naming to match global standards #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when building rpm packages, riak-2.x.x names correctly e.g. `riak-2.9.8-1.el8.x86_64.rpm` but the riak-3.x.x rpms are missing a dot before the basearch i.e. `riak-3.0.6-1.el8x86_64.rpm`. This incredibly tiny fix re-adds the missing dot in the package name. I have already tested this successfully on one of the regular package builders we use to publish the binaries by creating a phony tag of riak-3.0.61 and building it accordingly: ``` [root@localhost riak]# ls rel/pkg/out/packages/ riak-3.0.61.OTP20.3-1.el8.src.rpm riak-3.0.61.OTP20.3-1.el8.x86_64.rpm riak-3.0.61.OTP20.3-1.el8.src.rpm.sha riak-3.0.61.OTP20.3-1.el8.x86_64.rpm.sha ```
martinsumner
approved these changes
Jun 28, 2021
|
Please feel free to merge and delete when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when building rpm packages, riak-2.x.x names correctly e.g.
riak-2.9.8-1.el8.x86_64.rpmbut the riak-3.x.x rpms are missing a dot before the basearch i.e.riak-3.0.6-1.el8x86_64.rpm. This incredibly tiny fix re-adds the missing dot in the package name.I have already tested this successfully on one of the regular package builders we use to publish the binaries by creating a phony tag of riak-3.0.61 and building it accordingly: