Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: general codebase improvements #2888

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Aug 7, 2024

Overview

  • Mostly style changes, but also replaced some old/deprecated code.

@csatib02 csatib02 added the kind/enhancement Categorizes issue or PR as related to an improvement. label Aug 7, 2024
@csatib02 csatib02 self-assigned this Aug 7, 2024
@csatib02 csatib02 requested a review from a team as a code owner August 7, 2024 12:28
@csatib02 csatib02 removed the request for review from a team August 7, 2024 12:28
@github-actions github-actions bot added the size/L Denotes a PR that changes 500-999 lines label Aug 7, 2024
ramizpolic
ramizpolic previously approved these changes Aug 8, 2024
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Makefile Outdated Show resolved Hide resolved
cmd/bank-vaults/common.go Outdated Show resolved Hide resolved
pkg/kv/gcs/gcs.go Show resolved Hide resolved
Signed-off-by: Bence Csati <[email protected]>
@csatib02 csatib02 merged commit 3473e4c into main Aug 9, 2024
17 checks passed
@csatib02 csatib02 deleted the refactor/general-codebase-improvements branch August 9, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to an improvement. size/L Denotes a PR that changes 500-999 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants