Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(usage): add usage and adopter #2595

Merged
merged 3 commits into from
Apr 4, 2024
Merged

docs(usage): add usage and adopter #2595

merged 3 commits into from
Apr 4, 2024

Conversation

rljohnsn
Copy link
Contributor

Overview

Adds usage example and adopter

Notes for reviewer

@rljohnsn rljohnsn requested a review from a team as a code owner March 27, 2024 16:53
@rljohnsn rljohnsn requested review from sagikazarmark and removed request for a team March 27, 2024 16:53
@CLAassistant
Copy link

CLAassistant commented Mar 27, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines label Mar 27, 2024
@rljohnsn rljohnsn changed the title Doc/usage config helm chart docs(usage): add usage and adopter Mar 27, 2024
@rljohnsn rljohnsn force-pushed the doc/usage-config-helm-chart branch from c21c461 to 349da79 Compare March 27, 2024 16:58
@csatib02 csatib02 added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 27, 2024
csatib02
csatib02 previously approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@csatib02 csatib02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

README.md Outdated Show resolved Hide resolved
@rljohnsn
doc(usages): typo
37fd712 
Signed-off-by: rljohnsn <[email protected]>
ramizpolic
ramizpolic approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@ramizpolic ramizpolic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramizpolic ramizpolic merged commit cd2d8a8 into bank-vaults:main Apr 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramizpolic ramizpolic ramizpolic approved these changes

@csatib02 csatib02 csatib02 left review comments

@sagikazarmark sagikazarmark Awaiting requested review from sagikazarmark sagikazarmark is a code owner automatically assigned from bank-vaults/maintainers

Assignees
No one assigned
Labels
kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rljohnsn @CLAassistant @ramizpolic @csatib02