Acceptance tests in Go #1864
Merged
Acceptance tests in Go #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akijakya
force-pushed
the
acceptance-tests-in-go
branch
13 times, most recently
from
8f01f14
to
0d6d785
Compare
akijakya
requested review from
bonifaido,
pbalogh-sa and
sagikazarmark
as code owners
akijakya
force-pushed
the
acceptance-tests-in-go
branch
from
0d6d785
to
f67513f
Compare
akijakya
force-pushed
the
acceptance-tests-in-go
branch
from
f67513f
to
9e33176
Compare
akijakya
force-pushed
the
acceptance-tests-in-go
branch
from
9e33176
to
e86b4e5
Compare
bonifaido
approved these changes
Apr 20, 2023
I put some instructions as comment at the beginning of the test go file 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Switched from the shell script for acceptance test to go tests with the help of Terratest.
Tests are now running in a matrix of the supported k8s versions (1.25, 1.24, 1.23) and the supported Vault versions (1.13, 1.12, 1.11, 1.10) in a reduced timeframe.
Tests could also be ran locally in parallel as each test runs in its own namespace (tests unfortunately always failed for some reason when ran in parallel on Github Actions runners).
Why?
So all the supported Kubernetes and Vault versions could be tested for the same time it took previously.
Checklist
Related Helm chart(s) updated (if needed)To Do