Bug appneta#385 prevent Coverity copy/paste false positive

baigubulu · May 8, 2017 · 7322b8f · 7322b8f
1 parent 07c9b15
commit 7322b8f
Showing 1 changed file with 7 additions and 11 deletions.
diff --git a/src/common/interface.c b/src/common/interface.c
@@ -54,19 +54,15 @@ get_interface(interface_list_t *list, const char *alias)
 
     assert(alias);
 
-    if (list != NULL) {
-        ptr = list;
-
-        do {
-            /* check both the alias & name fields */
-            if (strcmp(alias, ptr->alias) == 0)
-                return(ptr->name);
+    ptr = list;
 
-            if (strcmp(alias, ptr->name) == 0)
-                return(ptr->name);
+    while (ptr) {
+        /* check both the alias & name fields */
+        if (strcmp(alias, ptr->alias) == 0 ||
+                strcmp(alias, ptr->name) == 0)
+            return(ptr->name);
 
-            ptr = ptr->next;
-        } while (ptr != NULL);
+        ptr = ptr->next;
     }
 
     return(NULL);