Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poppunk assign fix #298

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Poppunk assign fix #298

merged 2 commits into from
Dec 15, 2023

Conversation

samhorsfield96
Copy link
Collaborator

Corrects issue where new clusters were incorrectly assigned to previous internal cluster IDs.

@samhorsfield96
Update network.py
6090481 
Corrects issue where new clusters were incorrectly assigned to previously defined clusters.
@samhorsfield96
Update __init__.py
b28fd91 
Updates to v2.6.4
johnlees
johnlees approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@johnlees johnlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tricky one, thanks for sorting!

Can you just leave the version as-is, then we can release this as 2.6.3 when merged. I've approved so you can merge when ready.

@samhorsfield96 samhorsfield96 merged commit 6cae83c into bacpop:master Dec 15, 2023
@samhorsfield96 samhorsfield96 deleted the poppunk_assign_fix branch July 19, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnlees johnlees johnlees approved these changes

Assignees

@johnlees johnlees

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samhorsfield96 @johnlees