This repository has been archived by the owner on May 11, 2018. It is now read-only.
Normalize module format of plugins/built-ins data #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtsao
changed the title
|
I'm cool with the refactor and we probably won't change the file but we can't 100% guarantee that as a public "API" |
|
Thanks, that's good enough for me. I think ideally #373 is made part of the actual API, but since there was lot of pushback, this will suffice until there's a larger discussion. |
This was referenced Oct 17, 2017
This was referenced Feb 2, 2018
This was referenced Apr 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight refactor of
data/plugin-features.jsthat makes it match the same format ofdata/built-in-features.jswhere the data is organized by ECMAScript year.Resolves #373 by allowing package authors to import
babel-preset-env/data/plugin-features.jsandbabel-preset-env/data/built-in-features.jsand assemble the desired exclusions/inclusions (corresponding to a language target) on their own. There's no need for a first-class interface as long as the format ofdata/plugin-features.jsanddata/built-in-features.jsis preserved (whereby a clean userland implementation is possible).Note: this PR does not alter the output produced by the
build-datascript in any way. The output is byte-for-byte exactly as what is currently committed to master.