Skip to content
This repository has been archived by the owner on May 11, 2018. It is now read-only.

Fill data with electron as a target. #229

Merged
merged 11 commits into from
Mar 29, 2017
Merged

Fill data with electron as a target. #229

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
638f877
Add electron to build-data
yavorsky Mar 28, 2017
aa17e4b
Remove excess sort
yavorsky Mar 28, 2017
2c52021
Add yarn
yavorsky Mar 28, 2017
d60010f
Add debug fixtures for electron.
yavorsky Mar 28, 2017
3665653
Remove getTargets + electron from tests.
yavorsky Mar 28, 2017
7c43c0e
Remove electron to chrome stuff.
yavorsky Mar 28, 2017
a61932a
electron-to-chromium is devDep now
yavorsky Mar 28, 2017
e928cf7
Remove unused electronToChromiumData.
yavorsky Mar 28, 2017
40eb3b2
Fix closest chrome for intermediate values.
yavorsky Mar 28, 2017
c995506
Fix lint issue
yavorsky Mar 28, 2017
fef4820
bump electron-to-chromium for safety
existentialism Mar 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix closest chrome for intermediate values.
  • Loading branch information
@yavorsky
yavorsky committed Mar 28, 2017
commit 40eb3b2a2629081d7c0baca84248c53140a57614
8 changes: 4 additions & 4 deletions data/plugins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"node": 5,
"ios": 10,
"opera": 33,
"electron": 0.35
"electron": 0.36
},
"transform-es2015-computed-properties": {
"chrome": 44,
Expand Down Expand Up @@ -117,7 +117,7 @@
"node": 5,
"ios": 10,
"opera": 33,
"electron": 0.35
"electron": 0.36
},
"transform-es2015-parameters": {
"chrome": 49,
Expand Down Expand Up @@ -147,7 +147,7 @@
"node": 5,
"ios": 10,
"opera": 33,
"electron": 0.35
"electron": 0.36
},
"transform-es2015-sticky-regex": {
"chrome": 49,
Expand Down Expand Up @@ -215,7 +215,7 @@
"safari": 10.1,
"node": 7.6,
"opera": 42,
"electron": 1.5
"electron": 1.6
},
"syntax-trailing-function-commas": {
"chrome": 58,
Expand Down
10 changes: 4 additions & 6 deletions scripts/build-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,10 @@ const findClosestElectronVersion = (targetVersion) => {
const chromiumVersionsLength = chromiumToElectronVersions.length;
const maxChromium = +chromiumToElectronVersions[chromiumVersionsLength - 1];
if (targetVersion > maxChromium) return null;
const closestChrome = chromiumToElectronVersions.reduce((result, version) => {
if (targetVersion >= version) {
return version;
}
return result;
});

const closestChrome = chromiumToElectronVersions.find(
(version) => targetVersion <= version
);
return chromiumToElectronMap[closestChrome];
};

Expand Down