Skip to content
This repository has been archived by the owner on May 11, 2018. It is now read-only.

Remove unnecessary extension #131

Merged
merged 1 commit into from
Jan 9, 2017
Merged

Remove unnecessary extension #131

merged 1 commit into from
Jan 9, 2017

Conversation

roman-yakobnyuk
Copy link
Contributor

Removed unnecessary .js extension and fixed tests.

@hzoo
Copy link
Member

hzoo commented Jan 9, 2017

Ok this looks great!

I just realized I gave the wrong instructions though so we need to change https://github.com/babel/babel-preset-env/blob/master/data/built-in-features.js#L123 too

const es2016 = {
  "es7.array.includes.js": "Array.prototype.includes",
};

@roman-yakobnyuk
Copy link
Contributor Author

Updated the branch to include this change too, all tests seem fine too.

@existentialism
Copy link
Member

Nice work @roman-yakobnyuk!

@hzoo
Copy link
Member

hzoo commented Jan 9, 2017

yeah data/built-in-features.js is the hardcoded data and the other file is generated via npm run build-data but didn't want to make it too complicated - will merge once CI passes.

@hzoo hzoo merged commit 8eb0c07 into babel:master Jan 9, 2017
@hzoo
Copy link
Member

hzoo commented Jan 9, 2017

Oh yeah a tip: you can put Fixes #issue-number-here in the description/commit message and it will automatically close the corresponding issue. (I could of did this when merging but forgot)

@roman-yakobnyuk
Copy link
Contributor Author

Will keep that in mind for future, thanks!

@codeincontext
Copy link

Just so you're aware, this PR caused our config to break. It's easy to fix but I wonder if this could have been a minor server bump

@hzoo
Copy link
Member

hzoo commented Jan 12, 2017

I had no idea @skattyadz, I'm not sure why I had it originally and so I figured it was unnecessary (thus no reason for just a patch bump).

Can you explain the error and all that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants