Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use webpack builtin schema util #1030

Merged
merged 1 commit into from
Jul 24, 2024
Merged

refactor: use webpack builtin schema util #1030

merged 1 commit into from
Jul 24, 2024
+174 −88

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 23, 2024

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other information:
Use webpack builtin schema validation utils and remove schema-utils from dependencies. The schema-utils is a dependency of webpack anyway.

Also added a few tests for options validation.

@JLHwung JLHwung requested a review from liuxingbaoyu July 23, 2024 16:25
@JLHwung JLHwung merged commit d85f420 into main Jul 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JLHwung @liuxingbaoyu