Fix system transformer to ensure consistent modules iteration #4832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzoo
added
the
PR: Bug Fix 🐛
hzoo
approved these changes
Nov 11, 2016
Current coverage is 89.28% (diff: 100%)@@ master #4832 diff @@
==========================================
Files 196 196
Lines 13812 13816 +4
Methods 1434 1436 +2
Messages 0 0
Branches 3210 3211 +1
==========================================
+ Hits 12331 12335 +4
Misses 1481 1481
Partials 0 0
|
guybedford
added a commit
to systemjs/builder
that referenced
this pull request
Nov 12, 2016
guybedford
added a commit
to systemjs/builder
that referenced
this pull request
Jan 19, 2017
guybedford
added a commit
to systemjs/builder
that referenced
this pull request
Jan 23, 2017
guybedford
added a commit
to systemjs/builder
that referenced
this pull request
Jan 23, 2017
guybedford
added a commit
to systemjs/builder
that referenced
this pull request
Jan 24, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the system module transformer, the list of module specifiers
modulesis used as an ordered object and iterated viafor (let sourceName in modules)to output the dependency and setters lists. Relying on plain object property ordering doesn't work for numeric values in JavaScript though.To make this process more consistent this updates
modulesto an array which can then be iterated reliably. It fixes faulty ordering for cases where module names are numbers, as in the test provided.