Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start babel-types tests, add isNodesEquivalent #3553

Merged
merged 1 commit into from
Nov 15, 2016
Merged

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Jun 27, 2016

No description provided.

@@ -474,7 +474,8 @@ export {
isVar,
isSpecifierDefault,
isScope,
isImmutable
isImmutable,
isNodesEquivalent
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary since we aren't using export *

@hzoo hzoo force-pushed the add-is-nodes-equiv branch from 56639bd to 5293f19 Compare June 27, 2016 14:20
@codecov-io
Copy link

codecov-io commented Jun 27, 2016

Current coverage is 87.89%

Merging #3553 into master will decrease coverage by 0.01%

@@             master      #3553   diff @@
==========================================
  Files           194        194          
  Lines          9638       9674    +36   
  Methods        1100       1103     +3   
  Messages          0          0          
  Branches       2204       2215    +11   
==========================================
+ Hits           8473       8503    +30   
- Misses         1165       1171     +6   
  Partials          0          0          

Powered by Codecov. Last updated by 7a15409...5293f19

@hzoo hzoo added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Jun 27, 2016
@jmm
Copy link
Member

jmm commented Jun 27, 2016

Definitely in favor of getting tests going for babel-types; I need to merge #3267 =D (There's also #3174 that'll need feedback if it's going to proceed, as it changes public API.)

I was also wondering about the ES6 aspect -- see last sentence here: #3267 (comment). I think it's only top-level test files that aren't going through babel-register anyway. If a test file require()'s other modules I think those go through the require hook.

@hzoo
Copy link
Member Author

hzoo commented Jun 28, 2016

@jmm lol probably the longest PR open for a while..

Yeah definetely want to be able to use es2015 since it's just weird to switch back and forth

@hzoo hzoo merged commit 6a6ec87 into master Nov 15, 2016
@hzoo hzoo deleted the add-is-nodes-equiv branch November 19, 2016 16:57
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants