Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Babel 8]: rename typeParameters to typeArguments for TSClassImplements and TSInterfaceHeritage #17017

Merged
merged 6 commits into from
Dec 11, 2024
Merged

[Babel 8]: rename typeParameters to typeArguments for TSClassImplements and TSInterfaceHeritage #17017

merged 6 commits into from
Dec 11, 2024

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Dec 10, 2024 •
edited
Loading

Q                       A
Fixed Issues? #16679
Patch: Bug Fix?
Major: Breaking Change? Yes
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link babel/website#3028
Any Dependency Changes?
License MIT

@JLHwung JLHwung added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release PR: Needs Docs labels Dec 10, 2024
@babel-bot
Copy link
Collaborator

babel-bot commented Dec 10, 2024 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58465

This was referenced Dec 10, 2024
Open
Merged
nicolo-ribaudo
nicolo-ribaudo reviewed Dec 10, 2024
View reviewed changes
packages/babel-generator/src/generators/deprecated.ts

export type DeprecatedBabel7ASTTypes = "Noop" | "TSExpressionWithTypeArguments";

export function addDeprecatedGenerators(PrinterClass: typeof Printer) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@JLHwung JLHwung merged commit 8b6fb94 into babel:main Dec 11, 2024
55 checks passed
@JLHwung JLHwung deleted the ts-class-implements-type-arguments branch December 11, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees
No one assigned
Labels
PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JLHwung @babel-bot @nicolo-ribaudo @liuxingbaoyu