Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename TSTypeReference.typeParameters to typeArguments #17008

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Rename TSTypeReference.typeParameters to typeArguments #17008

merged 4 commits into from
Dec 6, 2024

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Dec 5, 2024 •
edited
Loading

Q                       A
Fixed Issues? Towards #16679
Patch: Bug Fix?
Major: Breaking Change? Yes
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link babel/website#3023
Any Dependency Changes?
License MIT

In this PR we rename the typeParameters property of the TSTypeReference node to typeArguments.

This PR contains commits from #17010, please review that PR first.

@JLHwung JLHwung added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release pkg: parser PR: Needs Docs labels Dec 5, 2024
@JLHwung JLHwung added this to the v8.0.0-beta milestone Dec 5, 2024
@babel-bot
Copy link
Collaborator

babel-bot commented Dec 5, 2024 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58447

@JLHwung JLHwung mentioned this pull request Dec 5, 2024
Merged
@JLHwung JLHwung force-pushed the tstypereference-type-arguments branch 2 times, most recently from 1ed5f50 to 1c5702f Compare December 6, 2024 00:36
@nicolo-ribaudo
Copy link
Member

Could you rebase? :)

@JLHwung JLHwung force-pushed the tstypereference-type-arguments branch from 1c5702f to 8907d0c Compare December 6, 2024 14:41
@JLHwung JLHwung mentioned this pull request Dec 6, 2024
Merged
@nicolo-ribaudo nicolo-ribaudo changed the title rename TSTypeReference.typeParameters to typeArguments Rename TSTypeReference.typeParameters to typeArguments Dec 6, 2024
@nicolo-ribaudo nicolo-ribaudo merged commit c7f26c8 into babel:main Dec 6, 2024
55 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the tstypereference-type-arguments branch December 6, 2024 15:30
@JLHwung JLHwung restored the tstypereference-type-arguments branch December 6, 2024 16:39
@JLHwung JLHwung deleted the tstypereference-type-arguments branch December 6, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees
No one assigned
Labels
pkg: parser PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release
Projects
None yet
Milestone
v8.0.0-beta
Development

Successfully merging this pull request may close these issues.
4 participants
@JLHwung @babel-bot @nicolo-ribaudo @liuxingbaoyu