[babel 8] Rename superTypeParameters -> superTypeArguments
#16997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Breaking Change 💥
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58444 |
nicolo-ribaudo
force-pushed
the
rename-superTypeParameters-to-superTypeArguments
branch
from
9d8abd5 to
a7ce086
Compare
JLHwung
reviewed
Dec 4, 2024
packages/babel-types/test/fields.js
Outdated
| @@ -22,6 +22,8 @@ const ignoredFields = { | |||
| TSDeclareMethod: { id: true }, | |||
| ...(process.env.BABEL_8_BREAKING | |||
| ? { | |||
| ClassExpression: { superTypeParameters: true }, | |||
| ClassDeclaration: { superTypeParameters: true }, | |||
There was a problem hiding this comment.
I will extract 763ebaa into a new PR so that we don't have to take care of Babel 7/8 AST changes in this test.
nicolo-ribaudo
force-pushed
the
rename-superTypeParameters-to-superTypeArguments
branch
from
7bdc2d4 to
30658c6
Compare
JLHwung
approved these changes
Dec 6, 2024
existentialism
approved these changes
Dec 6, 2024
liuxingbaoyu
approved these changes
Dec 6, 2024
nicolo-ribaudo
deleted the
rename-superTypeParameters-to-superTypeArguments
branch
|
Will open a docs PR soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general rule should be that parameters are what you receive, while arguments are what you pass to somebody else. We already apply this, for example, in function and call expressions.
We also need to rename some
.typeParametersto.typeArguments. This PR is the first easy step :)