Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): offset internal index locations by startIndex #16936

Merged
merged 6 commits into from
Oct 25, 2024
Merged

fix(parser): offset internal index locations by startIndex #16936

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e8d74ca
fix(babel-parser): all index locations from nodes need to be offset b…
DylanPiercey Oct 25, 2024
2bbdd4e
add tests and fix
liuxingbaoyu Oct 25, 2024
9496d23
Update packages/babel-parser/test/helpers/run-fixture-tests.js
liuxingbaoyu Oct 25, 2024
3e1e7ab
review
liuxingbaoyu Oct 25, 2024
f26314f
move
liuxingbaoyu Oct 25, 2024
5e28354
fix node 12
liuxingbaoyu Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix node 12
  • Loading branch information
@liuxingbaoyu
liuxingbaoyu committed Oct 25, 2024
commit 5e28354acdc38e521264cd9573d6ec4a7dd21efb
2 changes: 1 addition & 1 deletion packages/babel-parser/test/helpers/run-fixture-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ function runParseTest(parse, test, onlyCompareErrors, ignoreLocations) {
actual.ast &&
expected.ast &&
!actual.ast.errors &&
!options.plugins?.includes("estree") &&
!(options.plugins && options.plugins.includes("estree")) &&
!options.ranges
) {
removeLocations(actual.ast);
Expand Down
Loading