fix: Keep type annotations in syntacticPlaceholders mode
#16905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
liuxingbaoyu
commented
Oct 14, 2024
liuxingbaoyu
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #16904 |
| Patch: Bug Fix? | √ |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
liuxingbaoyu
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58137 |
| } | ||
|
|
||
| if (hasOwn(node, "typeAnnotation")) { | ||
| newNode.typeAnnotation = deep |
There was a problem hiding this comment.
Can we declare these various extra properties in the type definitions of Placehodler?
There was a problem hiding this comment.
export const PLACEHOLDERS = [
"Identifier",
"StringLiteral",
"Expression",
"Statement",
"Declaration",
"BlockStatement",
"ClassBody",
"Pattern",
] as const;
I'm afraid there are other properties that should be here, which would result in a large number of properties in the Placehodler type definition.
However, I haven't thought of a better way so far.
There was a problem hiding this comment.
Can they, though? For example, a placeholder will never have a .body because it's "inside" the node.
The identifier properties are special because they are not really inside the identifier, so they are not hidden by the placeholder.
JLHwung
force-pushed
the
fix-placeholder-type
branch
from
4f835bd to
d703353
Compare
nicolo-ribaudo
approved these changes
Oct 18, 2024
JLHwung
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.