Remove helper-builder-binary-assignment-operator-visitor #16895
Merged
+122
−271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Internal 🏠
nicolo-ribaudo
commented
Oct 9, 2024
| "=", | ||
| node.left, | ||
| build( | ||
| // todo: it could be a t.AsExpression |
There was a problem hiding this comment.
This todo was already there in the original implementation, and nobody ever discovered it 😬
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58195 |
JLHwung
reviewed
Oct 10, 2024
packages/babel-plugin-transform-exponentiation-operator/src/index.ts
Outdated
Show resolved
Hide resolved
nicolo-ribaudo
force-pushed
the
remove-helper-builder-binary-assignment-operator-visitor
branch
from
713c2eb to
c1225a4
Compare
JLHwung
approved these changes
Oct 23, 2024
liuxingbaoyu
approved these changes
Nov 8, 2024
nicolo-ribaudo
deleted the
remove-helper-builder-binary-assignment-operator-visitor
branch
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2This package was only used once, and had a bunch of generic logic that we don't need