Restore public API of resolvePlugin/resolvePreset
#16888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58098 |
JLHwung
approved these changes
Oct 9, 2024
| export const resolvePlugin = (name: string, dirname: string) => | ||
| resolvers.resolvePlugin(name, dirname, false).filepath; | ||
| export const resolvePreset = (name: string, dirname: string) => | ||
| resolvers.resolvePreset(name, dirname, false).filepath; |
There was a problem hiding this comment.
Since they are public, can we add a few test cases for them? It can be done in another PR.
|
Whops, I pushed two commits to the wrong PR |
nicolo-ribaudo
force-pushed
the
core-resolve-api
branch
from
14006ec to
84a80bf
Compare
liuxingbaoyu
approved these changes
Oct 9, 2024
|
I'm releasing a patch for this. |
This was referenced Oct 16, 2024
This was referenced Oct 31, 2024
This was referenced Nov 1, 2024
This was referenced Nov 1, 2024
This was referenced Nov 2, 2024
This was referenced Nov 2, 2024
This was referenced Nov 10, 2024
This was referenced Nov 10, 2024
Open
Open
Open
This was referenced Nov 11, 2024
Open
This was referenced Nov 12, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16887. We probably need a better API, but for now lets restore the old behavior.