Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove importReflection parser plugin #16808

Merged
merged 7 commits into from
Sep 7, 2024
Merged

Remove importReflection parser plugin #16808

merged 7 commits into from
Sep 7, 2024

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Sep 5, 2024 •
edited
Loading

Q                       A
Fixed Issues? Ref #16456
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link babel/website#2948
Any Dependency Changes?
License MIT

The proposal has been subsumed by sourcePhaseImports.

@nicolo-ribaudo nicolo-ribaudo added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release pkg: parser Spec: Import Reflection labels Sep 5, 2024
@nicolo-ribaudo nicolo-ribaudo added this to the v8.0.0-beta milestone Sep 5, 2024
@babel-bot
Copy link
Collaborator

babel-bot commented Sep 5, 2024 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57871

@nicolo-ribaudo nicolo-ribaudo force-pushed the remove-import-reflection branch from 7543843 to 497edf2 Compare September 5, 2024 13:37
JLHwung
JLHwung approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending prettier e2e tests update.

@nicolo-ribaudo nicolo-ribaudo merged commit 380e864 into babel:main Sep 7, 2024
52 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the remove-import-reflection branch September 7, 2024 08:53
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Sep 16, 2024
Closed
7 tasks
@fisker fisker mentioned this pull request Oct 1, 2024
Merged
4 tasks
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release Spec: Import Reflection
Projects
None yet
Milestone
v8.0.0-beta
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolo-ribaudo @babel-bot @JLHwung @liuxingbaoyu