Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Babel 8] Remove minimal,smart option of Pipeline Operator #16801

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

liuxingbaoyu
Copy link
Member

Q                       A
Fixed Issues? #16456
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Since the code we want to remove is heavily coupled with other code, maybe it will be much more convenient to remove it when Babel 8 is released. What do you think?

@babel-bot
Copy link
Collaborator

babel-bot commented Sep 4, 2024

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57911

@nicolo-ribaudo
Copy link
Member

Since the code we want to remove is heavily coupled with other code, maybe it will be much more convenient to remove it when Babel 8 is released. What do you think?

Sounds ok for me, since using the option will throw anyway

@nicolo-ribaudo
Copy link
Member

For the prettier test maybe we can use fsharp? I think it's a superset of minimal.

@liuxingbaoyu liuxingbaoyu added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release Spec: Pipeline Operator pkg: parser labels Sep 5, 2024
@nicolo-ribaudo nicolo-ribaudo added this to the v8.0.0-beta milestone Sep 11, 2024
@nicolo-ribaudo nicolo-ribaudo merged commit 63e8c44 into babel:main Sep 16, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: parser PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release PR: Needs Docs Spec: Pipeline Operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants