Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove importAssertions parser plugin #16770

Merged
merged 8 commits into from
Sep 7, 2024
Merged

Remove importAssertions parser plugin #16770

merged 8 commits into from
Sep 7, 2024

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Aug 23, 2024 •
edited
Loading

Q                       A
Fixed Issues? Ref #16456
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link babel/website#2948
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release pkg: parser PR: Needs Docs Spec: Import Attributes labels Aug 23, 2024
nicolo-ribaudo
nicolo-ribaudo commented Aug 23, 2024
View reviewed changes
...es/experimental/import-attributes-deprecatedAssertKeyword/invalid-escaped-assert/output.json
@@ -24,7 +24,7 @@
},
"value": "foo"
},
"assertions": []
"attributes": []
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test (and the other with a similar change) were meant to test the importAttributes plugin.

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Aug 23, 2024
Closed
7 tasks
@babel-bot
Copy link
Collaborator

babel-bot commented Aug 23, 2024 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57879

@nicolo-ribaudo nicolo-ribaudo added this to the v8.0.0-beta milestone Sep 3, 2024
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Sep 4, 2024
Closed
@nicolo-ribaudo

This comment was marked as outdated.

Sign in to view
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Sep 4, 2024
Merged
@nicolo-ribaudo nicolo-ribaudo force-pushed the remove-parser-importAssertions branch from 023da7b to b3bc600 Compare September 7, 2024 08:57
@nicolo-ribaudo nicolo-ribaudo merged commit ca62240 into babel:main Sep 7, 2024
53 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the remove-parser-importAssertions branch September 7, 2024 09:18
@fisker fisker mentioned this pull request Oct 30, 2024
Closed
4 tasks
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release Spec: Import Attributes
Projects
None yet
Milestone
v8.0.0-beta
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolo-ribaudo @babel-bot @liuxingbaoyu