Add TSClassImplements|TSInterfaceHeritage and rename TsExpressionWithTypeArguments in Babel 8
#16731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57969 |
liuxingbaoyu
force-pushed
the
TSClassImplements
branch
from
741bdfe to
cdab11e
Compare
liuxingbaoyu
commented
Aug 10, 2024
packages/babel-parser/src/types.ts
Outdated
Comment on lines
1732
to
1733
| // TS uses "heritageClauses", but want this to resemble ClassBase. | ||
| extends?: TsExpressionWithTypeArguments[]; | ||
| extends?: TSClassImplements[]; |
There was a problem hiding this comment.
There is something wrong here.
liuxingbaoyu
force-pushed
the
TSClassImplements
branch
from
a7c8aef to
4de73b6
Compare
liuxingbaoyu
changed the title
TSClassImplements and rename TsExpressionWithTypeArguments in Babel 8TSClassImplements|TSInterfaceHeritage and rename TsExpressionWithTypeArguments in Babel 8
nicolo-ribaudo
approved these changes
Sep 3, 2024
|
Although this adds a new AST in Babel 7, this won't be available until Babel 8, so we can probably merge it in a patch release. |
liuxingbaoyu
added
PR: Breaking Change 💥
Co-authored-by: Nicolò Ribaudo <[email protected]>
This reverts commit d09d988.
nicolo-ribaudo
force-pushed
the
TSClassImplements
branch
2 times, most recently
from
cf9c127 to
da08dab
Compare
nicolo-ribaudo
force-pushed
the
TSClassImplements
branch
from
da08dab to
6d2cf58
Compare
I changed this PR to only expose it in |
|
This is an AST breaking change, it should not have been merged without a docs PR. @liuxingbaoyu Could you open a docs PR? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since just renaming the AST in Babel 8 would require changing more of the test suite, I've added it in Babel 7 as well.