Respect NODE_ENV/BABEL_ENV in preset-react

babel · Oct 23, 2024 · b941657 · b941657
1 parent 816b293
commit b941657
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 5 deletions.
diff --git a/packages/babel-preset-react/src/index.ts b/packages/babel-preset-react/src/index.ts
@@ -21,7 +21,7 @@ export default declarePreset((api, opts: Options) => {
   api.assertVersion(REQUIRED_VERSION(7));
 
   const {
-    development,
+    development = process.env.BABEL_8_BREAKING ? api.env("development") : true,
     importSource,
     pragma,
     pragmaFrag,

diff --git a/packages/babel-preset-react/src/normalize-options.ts b/packages/babel-preset-react/src/normalize-options.ts
@@ -40,7 +40,6 @@ export default function normalizeOptions(options: any = {}) {
     const development = v.validateBooleanOption(
       TopLevelOptions.development,
       options.development,
-      false,
     );
     let importSource = v.validateStringOption(
       TopLevelOptions.importSource,
@@ -103,7 +102,8 @@ export default function normalizeOptions(options: any = {}) {
       pragmaFrag = pragmaFrag || "React.Fragment";
     }
 
-    const development = !!options.development;
+    const development =
+      options.development == null ? undefined : !!options.development;
 
     return {
       development,

diff --git a/packages/babel-preset-react/test/index.js b/packages/babel-preset-react/test/index.js
@@ -1,3 +1,5 @@
+import * as babel from "@babel/core";
+
 import _reactPreset from "../lib/index.js";
 const reactPreset = _reactPreset.default || _reactPreset;
 
@@ -24,4 +26,33 @@ describe("react preset", () => {
       `"@babel/preset-react: 'runtime' option must be a string."`,
     );
   });
+
+  itBabel8("respects envName", () => {
+    expect(
+      babel.transformSync("<a />", {
+        configFile: false,
+        presets: [reactPreset],
+        envName: "development",
+      }).code,
+    ).toMatchInlineSnapshot(`
+      "var _jsxFileName = \\"\\";
+      import { jsxDEV as _jsxDEV } from \\"react/jsx-dev-runtime\\";
+      /*#__PURE__*/_jsxDEV(\\"a\\", {}, void 0, false, {
+        fileName: _jsxFileName,
+        lineNumber: 1,
+        columnNumber: 1
+      }, this);"
+    `);
+
+    expect(
+      babel.transformSync("<a />", {
+        configFile: false,
+        presets: [reactPreset],
+        envName: "production",
+      }).code,
+    ).toMatchInlineSnapshot(`
+      "import { jsx as _jsx } from \\"react/jsx-runtime\\";
+      /*#__PURE__*/_jsx(\\"a\\", {});"
+    `);
+  });
 });
diff --git a/packages/babel-preset-react/test/normalize-options.skip-bundled.js b/packages/babel-preset-react/test/normalize-options.skip-bundled.js
@@ -59,7 +59,7 @@ describe("normalize options", () => {
     it("default values", () => {
       expect(normalizeOptions({})).toMatchInlineSnapshot(`
         Object {
-          "development": false,
+          "development": undefined,
           "importSource": "react",
           "pragma": undefined,
           "pragmaFrag": undefined,
@@ -70,7 +70,7 @@ describe("normalize options", () => {
       `);
       expect(normalizeOptions({ runtime: "classic" })).toMatchInlineSnapshot(`
         Object {
-          "development": false,
+          "development": undefined,
           "importSource": undefined,
           "pragma": "React.createElement",
           "pragmaFrag": "React.Fragment",