fix: remove promise from typings

babel · Oct 2, 2024 · 295a9d7 · 295a9d7
1 parent e19ee21
commit 295a9d7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/packages/babel-core/src/config/validation/plugins.ts b/packages/babel-core/src/config/validation/plugins.ts
@@ -85,8 +85,8 @@ export type PluginObject<S extends PluginPass = PluginPass> = {
     options: ValidatedOptions,
     parserOpts: ParserOptions,
   ) => void;
-  pre?: (this: S, file: File) => void | Promise<void>;
-  post?: (this: S, file: File) => void | Promise<void>;
+  pre?: (this: S, file: File) => void;
+  post?: (this: S, file: File) => void;
   inherits?: (
     api: PluginAPI,
     options: unknown,

diff --git a/packages/babel-core/src/transformation/index.ts b/packages/babel-core/src/transformation/index.ts
@@ -100,7 +100,6 @@ function* transformFile(file: File, pluginPasses: PluginPasses): Handler<void> {
           `You appear to be using an async plugin/preset, but Babel has been called synchronously`,
         );
 
-        // eslint-disable-next-line @typescript-eslint/no-floating-promises
         yield* fn.call(pass, file);
       }
     }
@@ -124,7 +123,6 @@ function* transformFile(file: File, pluginPasses: PluginPasses): Handler<void> {
           `You appear to be using an async plugin/preset, but Babel has been called synchronously`,
         );
 
-        // eslint-disable-next-line @typescript-eslint/no-floating-promises
         yield* fn.call(pass, file);
       }
     }