Use AbsoluteUri in FakeNavigationManager to preserve escpaed uri's #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for this. I don't see a reason this should affect existing users. Do you? |
|
Only if someone was relying on unescaped url's from the FakeNavigationManager :D |
egil
requested changes
Jul 21, 2021
src/bunit.web/TestDoubles/NavigationManager/FakeNavigationManager.cs
Outdated
Show resolved
Hide resolved
|
Oh yeah, remember to update the changelog.md file accordingly. |
Co-authored-by: Egil Hansen <[email protected]>
|
In favor of your latest change. It has less side effects. |
egil
previously approved these changes
Jul 22, 2021
|
Ahh, a can you fix the test? Then ill merge. |
|
Fixed @egil The test also just tests for the "raw" input aka |
egil
approved these changes
Jul 22, 2021
|
Merged. Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Fixes #458
In theory this is a API breaking change as Uri is different before than after the change.