Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: miscellaneous changes #458

Merged
merged 1 commit into from
Apr 4, 2024
Merged

chore: miscellaneous changes #458

merged 1 commit into from
Apr 4, 2024

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Apr 3, 2024 •
edited
Loading

  • marked some classes as readonly
  • fixes invalid psalm annotations ( mainly related to pure/mutation-free )
  • remove the use of promoted properties, this allows us to declare all properties using camelCase while still using snake_case for arguments.
  • declare some classes as immutable/mutation-free
  • declare some methods as mutation-free/pure
  • declare some functions as mutation-free/pure
  • remove redudnant type checks in Option::unzip as it is verified using @psalm-if-this-is
  • introduced Class\is_readonly function.

@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes. Type: BC Break A change that will result in a backward compatibility break in the public API. labels Apr 3, 2024
@azjezz azjezz added this to the 3.0.0 milestone Apr 3, 2024
@azjezz azjezz requested a review from veewee April 3, 2024 17:49
@azjezz azjezz self-assigned this Apr 3, 2024
@azjezz azjezz force-pushed the chore/misc branch 2 times, most recently from bcda228 to 8817580 Compare April 3, 2024 17:55
@coveralls
Copy link

coveralls commented Apr 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8545829459

Details

  • 78 of 78 (100.0%) changed or added relevant lines in 18 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 98.91%
Totals Coverage Status
Change from base Build 8524527937: 0.003%
Covered Lines: 4356
Relevant Lines: 4404
💛 - Coveralls

veewee
veewee approved these changes Apr 4, 2024
View reviewed changes
src/Psl/Class/is_readonly.php Show resolved Hide resolved
@azjezz azjezz merged commit 9ebf54f into next Apr 4, 2024
28 checks passed
@azjezz azjezz deleted the chore/misc branch April 4, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veewee veewee veewee approved these changes

Assignees

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: BC Break A change that will result in a backward compatibility break in the public API. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@azjezz @coveralls @veewee