Fix PHP84 implicit nullable types #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veewee
added
Priority: Low
Pull Request Test Coverage Report for Build 8524711209Details
💛 - Coveralls |
azjezz
approved these changes
Apr 2, 2024
|
@azjezz shall I merge + tag as 2.9.1 and then merge it back in next? |
|
@veewee yes please 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
The added cs-fixer rule will enforce that nullable types are always explicitly set.
This PR is targeted to 2.9.x to make that PHP 8.4 compatible as well.
Once merged, it should be merged to next (3.x) as well.