-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(type): add class_string types (#432) #435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerkms
force-pushed
the
432-class_string
branch
2 times, most recently
from
December 14, 2023 06:49
b0c85b4
to
a3c049e
Compare
Pull Request Test Coverage Report for Build 7219484447
💛 - Coveralls |
veewee
reviewed
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks very good.
I've added 2 little remarks to improve the tests a bit. But I think it's fine to go after this.
zerkms
force-pushed
the
432-class_string
branch
from
December 14, 2023 20:14
a3c049e
to
4c79e3d
Compare
veewee
added
Priority: Medium
This issue may be useful, and needs some attention.
Status: Completed
Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness
Type: Enhancement
Most issues will probably ask for additions or changes.
labels
Dec 15, 2023
renovate bot
referenced
this pull request
in ben-challis/sql-migrations
Dec 29, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [azjezz/psl](https://togithub.com/azjezz/psl) | `2.8.0` -> `2.9.0` | [![age](https://developer.mend.io/api/mc/badges/age/packagist/azjezz%2fpsl/2.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/azjezz%2fpsl/2.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/azjezz%2fpsl/2.8.0/2.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/azjezz%2fpsl/2.8.0/2.9.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>azjezz/psl (azjezz/psl)</summary> ### [`v2.9.0`](https://togithub.com/azjezz/psl/releases/tag/2.9.0): Lenalee - 2.9.0 [Compare Source](https://togithub.com/azjezz/psl/compare/2.8.0...2.9.0) #### What's Changed - Apply fixes for Psalm 5.17 by [@​veewee](https://togithub.com/veewee) in [https://github.com/azjezz/psl/pull/431](https://togithub.com/azjezz/psl/pull/431) - feat(type): add class_string types ([#​432](https://togithub.com/azjezz/psl/issues/432)) by [@​zerkms](https://togithub.com/zerkms) in [https://github.com/azjezz/psl/pull/435](https://togithub.com/azjezz/psl/pull/435) - feat(option): add `Option::zip()`, `Option::zipWith()` and `Option::unzip()` methods by [@​devnix](https://togithub.com/devnix) in [https://github.com/azjezz/psl/pull/434](https://togithub.com/azjezz/psl/pull/434) - feat(option): add `Option::proceed()` method by [@​devnix](https://togithub.com/devnix) in [https://github.com/azjezz/psl/pull/433](https://togithub.com/azjezz/psl/pull/433) - feat(option): new `Option::apply()` method by [@​devnix](https://togithub.com/devnix) in [https://github.com/azjezz/psl/pull/426](https://togithub.com/azjezz/psl/pull/426) #### New Contributors - [@​zerkms](https://togithub.com/zerkms) made their first contribution in [https://github.com/azjezz/psl/pull/435](https://togithub.com/azjezz/psl/pull/435) **Full Changelog**: azjezz/psl@2.8.0...2.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ben-challis/sql-migrations). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority: Medium
This issue may be useful, and needs some attention.
Status: Completed
Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness
Type: Enhancement
Most issues will probably ask for additions or changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #432
This PR creates a new
Type\class_string(T)
that allows to assert that the value is of a typeclass-string<T>
.Example of use: