feat(Core/Player): SendListInventory with vendor id #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisiver
changed the title
|
Once again, thanks @Foereaper for the support and thanks @tkn963 for submitting the PR. |
I'm about to test things. Do you have the sql for the creature 9000000 at hand? |
|
I used this one: SET
@Entry := 9000000,
@Model := 27822,
@Name := "Gabriella",
@Title := "The Assistant",
@Icon := "Speak",
@GossipMenu := 0,
@MinLevel := 30,
@MaxLevel := 30,
@Faction := 35,
@NPCFlag := 129,
@Scale := 1.0,
@Rank := 0,
@Type := 7,
@TypeFlags := 0,
@FlagsExtra := 16777218,
@Script := "";
-- Creature template
DELETE FROM `creature_template` WHERE `entry`=@Entry;
INSERT INTO `creature_template` (`entry`, `modelid1`, `name`, `subname`, `IconName`, `gossip_menu_id`, `minlevel`, `maxlevel`, `faction`, `npcflag`, `speed_walk`, `speed_run`, `scale`, `rank`, `unit_class`, `unit_flags`, `type`, `type_flags`, `RegenHealth`, `flags_extra`, `ScriptName`) VALUES
(@Entry, @Model, @Name, @Title, @Icon, @GossipMenu, @MinLevel, @MaxLevel, @Faction, @NPCFlag, 1, 1, @Scale, @Rank, 1, 2, @Type, @TypeFlags, 1, @FlagsExtra, @Script); |
|
Tested, works like a charm. This is a huge improvement actually. |
acidmanifesto
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated SendListInventory to allow specifying which vendor entry to send to the player.
Tested with a creature template entry of 9000000 with 129 set as npcflag and with a npc_vendor entry. The first option opens the vendor offered by the stormwind innkeeper while the second one defaults to the creature you're talking to.
All credit goes to Foe on Discord, whichever username that may be on Github.