NixOS support #906

misumisumi · 2023-07-28T05:57:31Z

TSInstall all installs and builds all treesitter
Binaries installed with mason.nvim work
- checked lua-language-server, pylsp, marksman.
- ~~Need to check for all binary packages? (maybe checking their dependencies instead, see below)~~
Can build from sources installed with mason.nvim
- Some packages have no upstream problem or identification of the cause. detail
wiki needs NixOS support description

using NixOS.

…ld` without" This reverts commit fe88597.

…raDependentPackages"

alias

This reverts commit 361abf0.

…s included in `nix-ld`'s NixOSModule

… as gcc

vollowx · 2023-07-28T08:04:07Z

nixos/neovim/default.nix

+              neovim-remote
+              ripgrep
+              sqlite
+              xclip


Not everyone are using desktop under X11, maybe it should be 2 options withWaylandClipboard (boolean) and withX11Clipboard (boolean) or withClipboard (string: 'wayland'|'x11').
Besides, most of the desktop users have already installed the related clipboard tools to their desktop as NeoVim is not the only program which need its support, so maybe it's also not necessary to install them at here, inside a NeoVim configuration.

Thank you for your review.
It is certainly so. It contained settings tailored to my environment.
As you can see from doc there are many options, so I won't support them here.
Note about the clipboard should be documented in the wiki.

Jint-lzxy · 2023-07-28T10:34:37Z

Need to check for all binary packages?

IMO it's unnecessary to check all those packages, it takes too much time as well as ur disk space. After #886 (comment), I installed all those packages on an external disk and dumped their dependencies using otool. I just did some sed-, sort- and uniqing, and these are the dependencies required by existing Mason packages (excluding dependencies managed by those "install mediums"):

libamd     <==> https://github.com/zship/libamd
libc       <==> https://www.gnu.org/software/libc/
  [OR] libc++ <==> https://libcxx.llvm.org/
libevent   <==> https://libevent.org/
libiconv   <==> https://www.gnu.org/software/libiconv/
libmsgpack <==> http://msgpack.org/
libz       <==> https://www.zlib.net/
libzstd    <==> https://github.com/facebook/zstd

FWIW this is actually similar to the compiling Treesitter's parsers, as long as all those dependencies are satisfied (and the dynamic linker is properly initialized), these executables should run with ease :D

misumisumi · 2023-07-28T12:59:48Z

IMO it's unnecessary to check all those packages, it takes too much time as well as ur disk space.

I understand remove from task

At least the LSP and Debugger, which were installed by default, have been built and verified.
We've made it possible to optionally include dependencies for the behavior of other packages, so you should be able to investigate and respond to them yourself.
It is enough to describe the method of investigation on the wiki.

Jint-lzxy · 2023-07-28T13:11:46Z

We've made it possible to optionally include dependencies for the behavior of other packages, so you should be able to investigate and respond to them yourself.
It is enough to describe the method of investigation on the wiki.

I think the same applies to "Some packages have no upstream problem or identification of the cause" too. If one really needs these individual builds, he can further tweak the base config to make that work (and usually they have such environment setup so fixing this won't be that difficult).

misumisumi · 2023-07-28T13:16:25Z

I understand Mark as completed.
Where should I submit a PR for the wiki description?
I'll post the base here if only admins can edit it.

ayamir · 2023-07-28T13:24:45Z

I'll post the base here if only admins can edit it.

You can edit it too.

Jint-lzxy · 2023-07-28T13:24:52Z

Where should I submit a PR for the wiki description?
I'll post the base here if only admins can edit it.

I remember last year we did tweak those wiki pages so that everyone can edit them. But if ur patch contains a lot of additions, it would be better to open an issue where we could do some proofreading before adding this (like #185).

misumisumi · 2023-08-09T03:35:00Z

yes.
Since this was created as a module for home-manager, it can also be used in nix-darwin as long as general user settings are configured with home-manager.

aarnphm

would be cool to also make this flake.nix compatible on darwin as well.

nixos/neovim/default.nix

nixos/default.nix

aarnphm · 2023-08-09T07:21:26Z

yes. Since this was created as a module for home-manager, it can also be used in nix-darwin as long as general user settings are configured with home-manager.

need to migrate my setup to home-manager 😄

Co-authored-by: Aaron Pham <[email protected]> Signed-off-by: MiSumiSumi <[email protected]>

nixos/neovim/default.nix

ayamir · 2023-08-18T16:26:59Z

Can it be merged?

misumisumi · 2023-08-19T03:34:46Z

Yeah.
After checking at hand, you can merge to main without conflict.

aarnphm

Oh I thought I submitted my review 😄 LGTM

nixos/neovim/default.nix

Jint-lzxy · 2023-08-19T05:34:21Z

I'll merge this after updating the docs :-) Thanks again for all the work here!

Jint-lzxy

LGTM! I will merge this if u think the Wiki Page is good (I made some minor modifications) 😄

cc @misumisumi @vollowx

vollowx · 2023-08-19T07:49:32Z

The link here should be updated as it may change in the future. Others are enough in my use case. 👍

Jint-lzxy · 2023-08-19T07:53:24Z

The link here should be updated as it may change in the future.

I will update this (using permalinks) after merging this PR, cause we currently don't have the stub for this file in the source tree :D

misumisumi · 2023-08-19T08:15:21Z

LGTM😄

misumisumi added 17 commits July 26, 2023 10:39

add(nixos): add build dependencies for mason.nvim on NixOS

72b54ba

update(options,setting): merged dont_set_python_host_prog

813ebac

add(nixos/neovim): Extend home-manager's programs.neovim.

4580c2f

add(flake): Providing the home-manager module.

24c49d6

add(nixos/dotnet): Provide dotnet NixOS module

2ec0bbb

feat(nixos/neovim): Correspondence to DotNET.

a13d983

feat(nixos/neovim): enabled nix-ld, your need install nix-ld without

dbadf18

using NixOS.

Revert "feat(nixos/neovim): enabled nix-ld, your need install `nix-…

af35feb

…ld` without" This reverts commit fe88597.

feat(nixos/neovim): Inspired by "nixos/modules/programs/nix-ld.nix".

6baf424

fix(nixos/neovim) rename option "extraBuildDependentPackages" to "ext…

2e2d3c9

…raDependentPackages"

feat(option): Set sqlite_clib_path from environment variable.

b65dc57

fix(nixos/neovim): add prefix "nvim-" to extraPrefix of buildEnv and fix

e9731fe

alias

add(nixos/neovim): add nix-ld to extraPackages

361abf0

Revert "add(nixos/neovim): add nix-ld to extraPackages"

e1c1cd8

This reverts commit 361abf0.

feat(nixos/neovim): add 'setBuildEnv' option

ce311e4

style(nixos): Change key of dotnet module

d809af5

feat(nixos/neovim): Set NIX_LD_LIBRARY_PATH myself. Including package…

49caa70

…s included in `nix-ld`'s NixOSModule

misumisumi changed the title ~~Nixos support using mason~~ Nixos support Jul 28, 2023

misumisumi changed the title ~~Nixos support~~ NixOS support Jul 28, 2023

feat(flake.nix): Change module name.

98bbe98

misumisumi force-pushed the nixos-support-using-mason branch from 68c4159 to 98bbe98 Compare July 28, 2023 06:09

fix(nixos/neovim): Remove deno and option to install build tools such…

d58caff

… as gcc

vollowx reviewed Jul 28, 2023

View reviewed changes

misumisumi force-pushed the nixos-support-using-mason branch from bf0d3a3 to 89f1927 Compare July 29, 2023 06:32

aarnphm reviewed Aug 9, 2023

View reviewed changes

nixos/neovim/default.nix Show resolved Hide resolved

nixos/default.nix Show resolved Hide resolved

misumisumi and others added 3 commits August 9, 2023 18:41

Update nixos/default.nix

c390f5d

Co-authored-by: Aaron Pham <[email protected]> Signed-off-by: MiSumiSumi <[email protected]>

feat(neovim/default.nix): Clean up language support

be7a1bf

feat(nixos): Include snips and tutor under $XDG_CONFIG_HOME/nvim

b310ddd

misumisumi force-pushed the nixos-support-using-mason branch from d82ce43 to b310ddd Compare August 12, 2023 17:42

aarnphm reviewed Aug 12, 2023

View reviewed changes

nixos/neovim/default.nix Outdated Show resolved Hide resolved

misumisumi added 2 commits August 13, 2023 11:49

fix(nixos): Fix stack extra-include-dirs and extra-lib-dirs

645846f

remove(nixos): Remove some language support

ddc2dce

aarnphm approved these changes Aug 19, 2023

View reviewed changes

nixos/neovim/default.nix Outdated Show resolved Hide resolved

fix(nixos): Remove alias settings

3e6da56

Jint-lzxy added 5 commits August 19, 2023 13:40

Merge branch 'main' into nixos-support-using-mason

38a0f33

fixups after merging 'main'

d145ef0

(nix) update docs

5ce0a8c

(readme) update docs

1728366

fixup! (readme) update docs

92b3150

Jint-lzxy approved these changes Aug 19, 2023

View reviewed changes

This was linked to issues Aug 19, 2023

NixOS support #886

Closed

[doc] Add NixOS and home-manager entry to wiki #908

Closed

Jint-lzxy merged commit 3a51040 into ayamir:main Aug 19, 2023
2 checks passed

TonyWu20 mentioned this pull request Aug 21, 2023

ayamir main TonyWu20/nvimdots#26

Merged

misumisumi deleted the nixos-support-using-mason branch August 28, 2023 20:26

TonyWu20 mentioned this pull request Sep 22, 2023

ayamir main TonyWu20/nvimdots#27

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NixOS support #906

NixOS support #906

misumisumi commented Jul 28, 2023 •

edited

Loading

vollowx Jul 28, 2023

misumisumi Jul 28, 2023

Jint-lzxy commented Jul 28, 2023

misumisumi commented Jul 28, 2023 •

edited

Loading

Jint-lzxy commented Jul 28, 2023

misumisumi commented Jul 28, 2023

ayamir commented Jul 28, 2023

Jint-lzxy commented Jul 28, 2023

misumisumi commented Aug 9, 2023

aarnphm left a comment

aarnphm commented Aug 9, 2023

ayamir commented Aug 18, 2023

misumisumi commented Aug 19, 2023

aarnphm left a comment

Jint-lzxy commented Aug 19, 2023

Jint-lzxy left a comment

vollowx commented Aug 19, 2023

Jint-lzxy commented Aug 19, 2023

misumisumi commented Aug 19, 2023

NixOS support #906

NixOS support #906

Conversation

misumisumi commented Jul 28, 2023 • edited Loading

vollowx Jul 28, 2023

Choose a reason for hiding this comment

misumisumi Jul 28, 2023

Choose a reason for hiding this comment

Jint-lzxy commented Jul 28, 2023

misumisumi commented Jul 28, 2023 • edited Loading

Jint-lzxy commented Jul 28, 2023

misumisumi commented Jul 28, 2023

ayamir commented Jul 28, 2023

Jint-lzxy commented Jul 28, 2023

misumisumi commented Aug 9, 2023

aarnphm left a comment

Choose a reason for hiding this comment

aarnphm commented Aug 9, 2023

ayamir commented Aug 18, 2023

misumisumi commented Aug 19, 2023

aarnphm left a comment

Choose a reason for hiding this comment

Jint-lzxy commented Aug 19, 2023

Jint-lzxy left a comment

Choose a reason for hiding this comment

vollowx commented Aug 19, 2023

Jint-lzxy commented Aug 19, 2023

misumisumi commented Aug 19, 2023

misumisumi commented Jul 28, 2023 •

edited

Loading

misumisumi commented Jul 28, 2023 •

edited

Loading