chore(kind_text): cleanup #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kagaya85
reviewed
Apr 12, 2023
| if opts.before then | ||
| vim_item = opts.before(entry, vim_item) | ||
| end | ||
| vim_item = opts.before and opts.before(entry, vim_item) |
There was a problem hiding this comment.
Hi there, In my usage scenario (neovim 0.9), I got an error in cmp.lua, I am not familiar with Lua but I found this change will cause the vim_item to have a null value, Is this a reasonable change?🥲
There was a problem hiding this comment.
do u have a screenshot of the error and the null cmp item?
There was a problem hiding this comment.
but from the logic, this should perform the same as the previous code.
There was a problem hiding this comment.
yeah, it just looks like this:
This error may occur when the opts.before is nil, so that the vim_item got a nil value ?
There was a problem hiding this comment.
hmmm, got it. seems like if opts.before is false, vim_item will return nil. Will send patch.
fecet
added a commit
to fecet/nvim
that referenced
this pull request
Apr 12, 2023
This reverts commit 80573d6.
fecet
added a commit
to fecet/nvim
that referenced
this pull request
Apr 12, 2023
This reverts commit 80573d6.
Jint-lzxy
added a commit
that referenced
this pull request
Apr 30, 2023
* chore(README): bump supported version * feat(options): support new options shipped with v0.9 * feat(scripts): support v0.9 * feat!: add initial support for lsp semantic tokens (#633) * feat(utils): use neovim builtin to get highlights (#632) * fix: remove deprecated options for nvim-tree. * fix(cmp): support dynamic `kind_text` from cmp source: `treesitter`, fix #624 #634 (#637) * fix&feat: introduce suda.vim to write file with sudo * chore(kind_text): cleanup (#648) * feat(alpha): add custom highlight groups (#650) * fix: install `psutils` by default for Windows users * revert: bind `SudaWrite` to `<A-s>` ref: #641 (comment) * fix(cmp): nil `vim_item` * perf(core-mapping): add some useful mapping * fix(nvim-tree): `hide_root_folder` is deprecated * perf: load fidget.nvim after `LspAttach` * minor fix 1. remove `<nop>` at "n|Q" 2. use visual mode instead of visual-line mode for "n|<C-a>" * perf: align style * perf(0.9): `stabilize.nvim` had been upstream to `0.9` * chore(project.nvim): update legacy code * chore(README): update branch info * chore(mapping): cleanup (#657) * fix(icon): update invalid cmp icon (#665) * chore/lspsaga_move (#667) * fix: paint word boundary in python (#669) * fix(bufferline): `show_buffer_default_icon` is now deprecate * feat(formatting): notify users for files under disabled dirs * chore(formatting): rephrase messages * fix(font-encoding): fix invalid characters on windows, fix #639 (#659) Co-authored-by: 冷酔閑吟 <[email protected]> * pref: unify code style for PowerShell commands * perf: better guidance to `Discussions` and `Wiki` (#680) * pref(ISSUE_TEMPLATE): fix typos and format with prettier * fixup! pref(ISSUE_TEMPLATE): fix typos and format with prettier * feat(scripts): abort for nvim v0.7 and its antecedent * feat(settings): allow customization of `transparent_background` (#687) * fix(bufferline): use defaults for `get_element_icon` (#685) * feat(auto-session): remember opened buffers (#688) * revert(keymap): remove redundant mappings. * fix(catppuccin): properly detect `g:colors_name` (#695) Ref: upstream breaking change [catppuccin/nvim@7a7a664] --------- Co-authored-by: ayamir <[email protected]> Co-authored-by: Charles Chiu <[email protected]> Co-authored-by: CharlesChiuGit <[email protected]> Co-authored-by: Xie Zejian <[email protected]> Co-authored-by: AngelontheRoad <[email protected]> Co-authored-by: Saafo <[email protected]>
singlemancombat
pushed a commit
to singlemancombat/nvim-config
that referenced
this pull request
May 1, 2023
* chore(README): bump supported version * feat(options): support new options shipped with v0.9 * feat(scripts): support v0.9 * feat!: add initial support for lsp semantic tokens (ayamir#633) * feat(utils): use neovim builtin to get highlights (ayamir#632) * fix: remove deprecated options for nvim-tree. * fix(cmp): support dynamic `kind_text` from cmp source: `treesitter`, fix ayamir#624 ayamir#634 (ayamir#637) * fix&feat: introduce suda.vim to write file with sudo * chore(kind_text): cleanup (ayamir#648) * feat(alpha): add custom highlight groups (ayamir#650) * fix: install `psutils` by default for Windows users * revert: bind `SudaWrite` to `<A-s>` ref: ayamir#641 (comment) * fix(cmp): nil `vim_item` * perf(core-mapping): add some useful mapping * fix(nvim-tree): `hide_root_folder` is deprecated * perf: load fidget.nvim after `LspAttach` * minor fix 1. remove `<nop>` at "n|Q" 2. use visual mode instead of visual-line mode for "n|<C-a>" * perf: align style * perf(0.9): `stabilize.nvim` had been upstream to `0.9` * chore(project.nvim): update legacy code * chore(README): update branch info * chore(mapping): cleanup (ayamir#657) * fix(icon): update invalid cmp icon (ayamir#665) * chore/lspsaga_move (ayamir#667) * fix: paint word boundary in python (ayamir#669) * fix(bufferline): `show_buffer_default_icon` is now deprecate * feat(formatting): notify users for files under disabled dirs * chore(formatting): rephrase messages * fix(font-encoding): fix invalid characters on windows, fix ayamir#639 (ayamir#659) Co-authored-by: 冷酔閑吟 <[email protected]> * pref: unify code style for PowerShell commands * perf: better guidance to `Discussions` and `Wiki` (ayamir#680) * pref(ISSUE_TEMPLATE): fix typos and format with prettier * fixup! pref(ISSUE_TEMPLATE): fix typos and format with prettier * feat(scripts): abort for nvim v0.7 and its antecedent * feat(settings): allow customization of `transparent_background` (ayamir#687) * fix(bufferline): use defaults for `get_element_icon` (ayamir#685) * feat(auto-session): remember opened buffers (ayamir#688) * revert(keymap): remove redundant mappings. * fix(catppuccin): properly detect `g:colors_name` (ayamir#695) Ref: upstream breaking change [catppuccin/nvim@7a7a664] --------- Co-authored-by: ayamir <[email protected]> Co-authored-by: Charles Chiu <[email protected]> Co-authored-by: CharlesChiuGit <[email protected]> Co-authored-by: Xie Zejian <[email protected]> Co-authored-by: AngelontheRoad <[email protected]> Co-authored-by: Saafo <[email protected]>
boomker
pushed a commit
to boomker/uvcode-nvim
that referenced
this pull request
May 2, 2023
* chore(README): bump supported version * feat(options): support new options shipped with v0.9 * feat(scripts): support v0.9 * feat!: add initial support for lsp semantic tokens (ayamir#633) * feat(utils): use neovim builtin to get highlights (ayamir#632) * fix: remove deprecated options for nvim-tree. * fix(cmp): support dynamic `kind_text` from cmp source: `treesitter`, fix ayamir#624 ayamir#634 (ayamir#637) * fix&feat: introduce suda.vim to write file with sudo * chore(kind_text): cleanup (ayamir#648) * feat(alpha): add custom highlight groups (ayamir#650) * fix: install `psutils` by default for Windows users * revert: bind `SudaWrite` to `<A-s>` ref: ayamir#641 (comment) * fix(cmp): nil `vim_item` * perf(core-mapping): add some useful mapping * fix(nvim-tree): `hide_root_folder` is deprecated * perf: load fidget.nvim after `LspAttach` * minor fix 1. remove `<nop>` at "n|Q" 2. use visual mode instead of visual-line mode for "n|<C-a>" * perf: align style * perf(0.9): `stabilize.nvim` had been upstream to `0.9` * chore(project.nvim): update legacy code * chore(README): update branch info * chore(mapping): cleanup (ayamir#657) * fix(icon): update invalid cmp icon (ayamir#665) * chore/lspsaga_move (ayamir#667) * fix: paint word boundary in python (ayamir#669) * fix(bufferline): `show_buffer_default_icon` is now deprecate * feat(formatting): notify users for files under disabled dirs * chore(formatting): rephrase messages * fix(font-encoding): fix invalid characters on windows, fix ayamir#639 (ayamir#659) Co-authored-by: 冷酔閑吟 <[email protected]> * pref: unify code style for PowerShell commands * perf: better guidance to `Discussions` and `Wiki` (ayamir#680) * pref(ISSUE_TEMPLATE): fix typos and format with prettier * fixup! pref(ISSUE_TEMPLATE): fix typos and format with prettier * feat(scripts): abort for nvim v0.7 and its antecedent * feat(settings): allow customization of `transparent_background` (ayamir#687) * fix(bufferline): use defaults for `get_element_icon` (ayamir#685) * feat(auto-session): remember opened buffers (ayamir#688) * revert(keymap): remove redundant mappings. * fix(catppuccin): properly detect `g:colors_name` (ayamir#695) Ref: upstream breaking change [catppuccin/nvim@7a7a664] --------- Co-authored-by: ayamir <[email protected]> Co-authored-by: Charles Chiu <[email protected]> Co-authored-by: CharlesChiuGit <[email protected]> Co-authored-by: Xie Zejian <[email protected]> Co-authored-by: AngelontheRoad <[email protected]> Co-authored-by: Saafo <[email protected]> (cherry picked from commit 08c4561)
TonyWu20
pushed a commit
to TonyWu20/nvimdots
that referenced
this pull request
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.