-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update instructions #14
base: branch-1.10.0
Are you sure you want to change the base?
Conversation
README.md
Outdated
@@ -15,11 +15,11 @@ Obtain a copy of Hive from GitHub at https://github.com/apache/hive. | |||
|
|||
To build the Hive client, you need to first apply this [patch](https://issues.apache.org/jira/secure/attachment/12958418/HIVE-12679.branch-2.3.patch). Download this patch and move it to your local Hive git repository you created above. Apply the patch and build Hive. | |||
|
|||
git checkout branch-2.3 | |||
git checkout tags/rel/release-2.3.4 -branch rel-2.3.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be "-b"?
git checkout tags/rel/release-2.3.4 -b rel-2.3.4
Note: I am running git version 2.17.2 (Apple Git-113)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, typo on my part. Thanks for the correction.
One other note: I was having trouble building hive getting an error I found that I had to add this to the pom.xml file to get it to resolve. I took this suggestion from https://stackoverflow.com/questions/4908651/the-following-artifacts-could-not-be-resolved-javax-jmsjmsjar1-1.
|
The artifact is on maven central -> https://search.maven.org/artifact/javax.jms/jms/1.1/jar |
I had to add the hadoop-common dependency to the spark-hive-shims pom directly but otherwise this also built fine on my system. It would be great to get this merged in, I spent much too long fighting w/ the build instructions before looking this issue. |
@mitochon I followed steps given at here. I am able to build client aws-glue-datacatalog-hive2-client, and I am not getting 2.3.4-SNAPSHOT as a release version while building hive, instead getting 2.3.4 version in my local m2 directory |
@gaurang101197 you should probably file an issue with more details of your situation A few sanity checks to try
Also as a disclaimer I'm just a contributor, not affiliated with AWS =) |
@mitochon I figured out the problem by carefully looking at the patch. In this patch, there is not property called |
Issue #, if available:
Description of changes:
Outdated step
branch-2.3
of hive will cause issues due to API change here that will cause this error downstreamerror: AWSCatalogMetastoreClient is not abstract and does not override abstract method listPartitionValues(PartitionValuesRequest) in IMetaStoreClient
Missing step
1.2
will put files into~/.m2/repository/org/apache/hive/
... whereas these need to be under~/.m2/repository/org/spark-project/hive/
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.