websocket write bug fix #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerZhongAWS
requested review from
HarshGandhi-AWS,
kareali and
marcoemorais-aws
HarshGandhi-AWS
approved these changes
Jul 21, 2022
kareali
suggested changes
Jul 21, 2022
|
@kareali I made sure the repo settings only allow for squash and merge for pull requests. Github should take care of the squashing and then I just edit the commit message before I close the PR. |
kareali
approved these changes
Jul 21, 2022
Sounds good, Just approved the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes bug where there is more than one outstanding call to web socket write.
Modifications
Change summary
Added mutex + lock_guard to protect outgoing message queue from concurrent access.
Testing
Changes have been tested with files >10 MB
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.