Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backward compatibility #150

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Fix backward compatibility #150

merged 4 commits into from
Apr 25, 2024

Conversation

RogerZhongAWS
Copy link
Contributor

@RogerZhongAWS RogerZhongAWS commented Apr 23, 2024

Motivation

  • Localproxy v3.1.1 does not work with localproxy v3.1.0 and localproxy v2 in certain scenarios.

Modifications

Change summary

  • Removed check on single service Id to fall back to V1 mode and instead trigger V1 mode based on user input only.
  • Added command line options for passing either V1 or V2 as a destination-client-type to switch between different backward compatible modes

Revision diff summary

If there is more than one revision, please explain what has been changed since the last revision.

Testing

Is your change tested? If not, please justify the reason.
Please list your testing steps and test results.
v3.1.1 localproxy → v3.1.1 localproxy

v3.1.1 localproxy → v3.1.0 localproxy

v3.1.0 localproxy → v3.1.1 localproxy

v3.1.1 localproxy → v2.3.1 localproxy

v2.3.1 localproxy → v3.1.1 localproxy

v3.1.1 localproxy → DC v1.9 using latest SDK

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@HarshGandhi-AWS HarshGandhi-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RogerZhongAWS RogerZhongAWS merged commit 9eace74 into main Apr 25, 2024
6 checks passed
@RogerZhongAWS RogerZhongAWS deleted the fix-backward-compatibility branch April 25, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants