Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix intermittent data loss after creating new connections #106

Merged
merged 16 commits into from
Nov 29, 2022
Merged

Fix intermittent data loss after creating new connections #106

merged 16 commits into from
Nov 29, 2022

Conversation

RogerZhongAWS
Copy link
Contributor

@RogerZhongAWS RogerZhongAWS commented Oct 28, 2022 •
edited
Loading

Motivation

  • Some users are reporting an issue where webpages would not finish loading over the secure tunnel connection.
  • The cause appears to be a timing issue within the local proxy. More specifically, a case where data packets arrive before the client is able to finish connecting to the tcp socket.

Modifications

Change summary

  • These changes fix the issue by changing all destination-side boost calls from asynchronous to synchronous, which makes the program wait until the tcp socket connection is confirmed active.

Revision diff summary

If there is more than one revision, please explain what has been changed since the last revision.

Testing

  • Tested with hundreds of http requests through curl and the browser.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@RogerZhongAWS
parent e089c89
1b2ab3c 
author Roger Zhong <[email protected]> 1665624317 -0700
committer Roger Zhong <[email protected]> 1667001000 -0700

disable socket delete
HarshGandhi-AWS
HarshGandhi-AWS approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@HarshGandhi-AWS HarshGandhi-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RogerZhongAWS RogerZhongAWS changed the title Fix socket issue Fix intermittent data loss after creating new connections Nov 29, 2022
@RogerZhongAWS RogerZhongAWS merged commit 4986b8b into main Nov 29, 2022
@RogerZhongAWS RogerZhongAWS deleted the fix-socket-issue branch November 29, 2022 19:40
RogerZhongAWS added a commit that referenced this pull request Dec 22, 2022
@RogerZhongAWS
Fix intermittent data loss after creating new connections (#106)
ae141fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlcheng1 xlcheng1 xlcheng1 approved these changes

@HarshGandhi-AWS HarshGandhi-AWS HarshGandhi-AWS approved these changes

@BolongZhang-AWS BolongZhang-AWS Awaiting requested review from BolongZhang-AWS

@shangabl shangabl Awaiting requested review from shangabl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RogerZhongAWS @HarshGandhi-AWS @xlcheng1