Skip to content

feat: make sign in button full width if not sign up button present #8447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

eddiekeller
Copy link
Contributor

Description of changes

This change detects if the hideSignUp property is enabled on the AmplifySignIn component and, if so, will render the "Sign In" button with the full width of the component container.

Sreenshot -
Screen Shot 2021-06-14 at 9 27 48 AM

Screen Shot 2021-06-14 at 12 45 29 PM

Issue #, if available

#7564

Description of how you validated changes

Testing locally in a sample app.

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@ericclemmons ericclemmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! Makes sense to me, and the screenshots sell it!

I expect that we'd want the next iteration to correctly make use of flex-box, but that's likely too difficult to apply to this implementation.

@eddiekeller eddiekeller merged commit d333997 into aws-amplify:main Jun 15, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants