Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-amplify-angular): remove util import to fix ng-12 build error #8369

Merged
merged 3 commits into from
Jun 1, 2021

Conversation

iartemiev
Copy link
Member

Description of changes

Remove unneeded util import that's causing a build error in Angular 12

Issue #, if available

#8347

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iartemiev iartemiev added the Angular Related to Angular 2+ label Jun 1, 2021
@iartemiev iartemiev requested a review from wlee221 June 1, 2021 14:26
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2021

Codecov Report

Merging #8369 (446f12c) into main (6f285c3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8369   +/-   ##
=======================================
  Coverage   77.85%   77.85%           
=======================================
  Files         239      239           
  Lines       16879    16879           
  Branches     3594     3594           
=======================================
  Hits        13141    13141           
  Misses       3627     3627           
  Partials      111      111           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f285c3...446f12c. Read the comment docs.

Copy link
Contributor

@wlee221 wlee221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @iartemiev!

@iartemiev iartemiev merged commit ea97dda into aws-amplify:main Jun 1, 2021
@iartemiev iartemiev deleted the fix-dep-ng-12 branch June 1, 2021 21:46
@github-actions
Copy link

github-actions bot commented Jun 2, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Angular Related to Angular 2+
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants