Remove algorithms from testmodulewrapper that are now used in the real modulewrapper #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
approved these changes
Dec 18, 2024
justsmth
approved these changes
Dec 19, 2024
andrewhop
force-pushed
the
testmodulewrappercleanup
branch
from
c913c89 to
0f2e315
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2069 +/- ##
==========================================
- Coverage 78.76% 78.76% -0.01%
==========================================
Files 598 598
Lines 103651 103650 -1
Branches 14720 14720
==========================================
- Hits 81636 81635 -1
+ Misses 21364 21363 -1
- Partials 651 652 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The testmodulewrapper is used to test ACVP things that the real modulewrapper doesn't support due to lack of support in libcrypto. We have added XTS and KDF to the modulewrapper and no longer need to test them here.
Testing:
Removed code, existing tests pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.