Add PKCS7_print_ctx as a no-op #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2064 +/- ##
=======================================
Coverage 78.77% 78.77%
=======================================
Files 598 598
Lines 103694 103703 +9
Branches 14735 14734 -1
=======================================
+ Hits 81681 81690 +9
+ Misses 21360 21358 -2
- Partials 653 655 +2 ☔ View full report in Codecov by Sentry. |
justsmth
approved these changes
Dec 18, 2024
skmcgrail
approved these changes
Dec 18, 2024
samuel40791765
force-pushed
the
pkcs7-print-noop
branch
from
9a1682e to
75dfacc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Ruby's mainline branch has added support for printing the contents for a PKCS7 structure:ruby/ruby@841b45a The hooks to print ASN1_items have been removed from AWS-LC, so this would require a lot for us to add back and support.
This is only a print function though, I think we can no-op this for a better build and indicate we don't support printing the contents.
Call-outs:
N/A
Testing:
Minor test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.