Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fuzz testing for PKCS7_verify #2051

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Dec 10, 2024

Description of changes:

  • Add fuzz testing around PKCS7_verify

Call-outs:

  • The only human-readable changes are in the first commit: bb68163

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.76%. Comparing base (51ae4b1) to head (f5e947c).

Files with missing lines Patch % Lines
crypto/pkcs7/pkcs7.c 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2051      +/-   ##
==========================================
- Coverage   78.77%   78.76%   -0.02%     
==========================================
  Files         598      598              
  Lines      103691   103695       +4     
  Branches    14734    14734              
==========================================
- Hits        81682    81672      -10     
- Misses      21357    21373      +16     
+ Partials      652      650       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth marked this pull request as ready for review December 10, 2024 22:23
@justsmth justsmth requested a review from a team as a code owner December 10, 2024 22:23
@justsmth justsmth marked this pull request as draft December 11, 2024 17:39
@justsmth justsmth force-pushed the pkcs7-verify-fuzz branch 3 times, most recently from cfd3033 to 6605fe8 Compare December 12, 2024 13:42
@justsmth justsmth marked this pull request as ready for review December 12, 2024 13:42
fuzz/pkcs7_verify.cc Outdated Show resolved Hide resolved
crypto/pkcs7/pkcs7.c Outdated Show resolved Hide resolved
@justsmth justsmth force-pushed the pkcs7-verify-fuzz branch 2 times, most recently from 9223279 to f41e86c Compare December 16, 2024 15:13
fuzz/pkcs7_verify.cc Outdated Show resolved Hide resolved
samuel40791765
samuel40791765 previously approved these changes Dec 16, 2024
@justsmth justsmth enabled auto-merge (squash) December 16, 2024 23:14
@justsmth justsmth merged commit c23791a into aws:main Dec 17, 2024
124 of 126 checks passed
@justsmth justsmth deleted the pkcs7-verify-fuzz branch December 17, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants