Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified posix builds to enable dilithium by default #2034

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Modified posix builds to enable dilithium by default #2034

merged 7 commits into from
Dec 18, 2024

Conversation

jakemas
Copy link
Contributor

@jakemas jakemas commented Dec 5, 2024

Issues:

Addresses #P175809809

Description of changes:

As we prepare ML-DSA and the removal of the enable_dilithium flag, we prepare our builds to all enable dilithium. This should also catch addition bugs in the CI.

One such bug has already been found by testing this addition, that has also been addressed in this PR:

In file included from /crypto/dilithium/ml_dsa.c:20:
/crypto/dilithium/./pqcrystals_dilithium_ref_common/sign.c: In function ‘crypto_sign_keypair_internal’:
/crypto/dilithium/./pqcrystals_dilithium_ref_common/sign.c:54:9: error: ‘s1’ may be used uninitialized [-Werror=maybe-uninitialized]
 54 | s1hat = s1;
 | ~~~~^~
crypto/dilithium/./pqcrystals_dilithium_ref_common/sign.c:35:12: note: ‘s1’ declared here
 35 | polyvecl s1, s1hat;
 | ^~

Testing:

Found through testing for linux builds/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@jakemas jakemas requested a review from a team as a code owner December 5, 2024 01:19
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (04a0f10) to head (7b5979d).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2034      +/-   ##
==========================================
- Coverage   78.77%   78.76%   -0.01%     
==========================================
  Files         598      598              
  Lines      103694   103694              
  Branches    14735    14734       -1     
==========================================
- Hits        81681    81672       -9     
- Misses      21360    21369       +9     
  Partials      653      653

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakemas
Copy link
Contributor Author

jakemas commented Dec 18, 2024

That's a lot of brackets 😂. Thanks!

@andrewhop andrewhop merged commit d0501c5 into aws:main Dec 18, 2024
123 of 126 checks passed
@jakemas jakemas mentioned this pull request Dec 19, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewhop andrewhop andrewhop approved these changes

@skmcgrail skmcgrail skmcgrail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakemas @codecov-commenter @skmcgrail @andrewhop