[EC] ec_nistp P-256 C scalar_mul_{base|public} #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2033 +/- ##
==========================================
- Coverage 78.68% 78.65% -0.03%
==========================================
Files 598 598
Lines 103347 103253 -94
Branches 14691 14677 -14
==========================================
- Hits 81319 81216 -103
- Misses 21375 21385 +10
+ Partials 653 652 -1 ☔ View full report in Codecov by Sentry. |
nebeid
approved these changes
Dec 23, 2024
torben-hansen
approved these changes
Dec 23, 2024
| @@ -17,9 +17,9 @@ | |||
| // |----------------------------| | |||
There was a problem hiding this comment.
Can remove this tracking table now?
Can be follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
N/A
Description of changes:
Use
ec_nistpimplementation for P-256 C code.Update
make_tables.goto generate the base pointtable in the same way as for P-384 and P-521.
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.