build: fix pkgconfig files #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
reviewed
Oct 9, 2024
justsmth
reviewed
Oct 9, 2024
justsmth
reviewed
Oct 9, 2024
| # This module provides function for joining paths | ||
| # known from most languages | ||
| # | ||
| # SPDX-License-Identifier: (MIT OR CC0-1.0) |
There was a problem hiding this comment.
A note for reference: Here's a link to the CC0-1.0 license: https://creativecommons.org/publicdomain/zero/1.0/
justsmth
reviewed
Oct 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1913 +/- ##
=======================================
Coverage 78.50% 78.50%
=======================================
Files 585 585
Lines 99681 99681
Branches 14265 14273 +8
=======================================
+ Hits 78257 78258 +1
Misses 20788 20788
+ Partials 636 635 -1 ☔ View full report in Codecov by Sentry. |
|
Hello @theoparis -- thanks for the PR! Is there an easy way to test this in our CI, so we can avoid a regression in the future? |
|
Hmm, I'm not sure what the best way of testing this kind of change would be. I made a Nix derivation here. Maybe it could be tested via a Nix github action? Nix is what reported the broken pkg-config paths. |
skmcgrail
approved these changes
Oct 15, 2024
justsmth
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently the pkgconfig files are broken when aws-lc is built with Nix.
See https://github.com/jtojnar/cmake-snips?tab=readme-ov-file#concatenating-paths-when-building-pkg-config-files, and the PR made to libfmt fmtlib/fmt#1657
Call-outs:
I'm not sure if bumping the minimum required CMake version is preferred. The alternative would be to add https://github.com/jtojnar/cmake-snips/blob/master/CMakeScripts/JoinPaths.cmake to the
cmake/directory in the repository. However, most linux distributions have at least CMake 3.20, if not 3.25 so I don't see why this would be a problem.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.