Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHA256 support #32

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Add SHA256 support #32

merged 1 commit into from
Aug 19, 2022

Conversation

parkerram
Copy link
Contributor

Issue #, if available: N/A

Description of changes: Adding support for Amazon SNS messages hashed using SHA256

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@devinstewart
Copy link

Hi @parkerram -
Not a maintainer here, but was curious why the validator should need to support SHA256 (signature version 2)?

On this documentation it states:

For Amazon SNS notifications, Amazon SNS currently supports signature version 1.

Is this out of date? In using SNS I have always seen my messages POST as signature version 1. Is there a way to force version 2?

Thanks in advance for any information.

@trivikr trivikr merged commit d7c45c7 into aws:master Aug 19, 2022
@parkerram
Copy link
Contributor Author

@devinstewart

Hello! Sorry for the late reply but checkout our newest blog post! https://aws.amazon.com/blogs/security/sign-amazon-sns-messages-with-sha256-hashing-for-http-subscriptions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants