Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spell out explicitly what visiting an UnsubscribeMessage SubscribeURL will do #15

Merged
merged 1 commit into from
Aug 24, 2017
Merged

Spell out explicitly what visiting an UnsubscribeMessage SubscribeURL will do #15

merged 1 commit into from
Aug 24, 2017

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Aug 23, 2017

The README was misleading in its UnsubscribeConfirmation handling example. Visiting the endpoint specified in the message's SubscribeURL will re-subscribe your server to the topic; staying unsubscribed requires no action.

@jeskew jeskew requested a review from chrisradek August 23, 2017 23:15
chrisradek
chrisradek approved these changes Aug 23, 2017
View reviewed changes
Copy link

@chrisradek chrisradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@jeskew jeskew merged commit 5e45a38 into aws:master Aug 24, 2017
@jeskew jeskew deleted the docs/fixup-readme-unsubscribe branch August 24, 2017 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisradek chrisradek chrisradek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeskew @chrisradek